Skip to content

[Zoom] Update existing scopes with granular scopes #113994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 7, 2024
Merged

[Zoom] Update existing scopes with granular scopes #113994

merged 4 commits into from
Oct 7, 2024

Conversation

moxarth-rathod
Copy link
Contributor

@moxarth-rathod moxarth-rathod commented Oct 3, 2024 •
edited
Loading

Part of elastic/connectors#2818

Existing permissions are deprecated in the Zoom developer app, replacing them with the new granular scopes - https://developers.zoom.us/docs/integrations/oauth-scopes-overview/.
Fyi, the cloud_recording:read:list_user_recordings:admin scope is not tested due to not having a pro account.

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against main? Unless there is a good reason otherwise, we prefer pull requests against main and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS and architecture that we support?
  • If you are submitting this code for a class then read our policy for that.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 3, 2024

Documentation preview:

@elasticsearchmachine elasticsearchmachine added v9.0.0 needs:triage Requires assignment of a team area label external-contributor Pull request authored by a developer outside the Elasticsearch team labels Oct 3, 2024
@moxarth-rathod moxarth-rathod mentioned this pull request Oct 3, 2024
Closed
@andreidan andreidan added >docs General docs changes and removed needs:triage Requires assignment of a team area label labels Oct 3, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine elasticsearchmachine added the Team:Docs Meta label for docs team label Oct 3, 2024
@leemthompo leemthompo self-assigned this Oct 3, 2024
leemthompo
leemthompo approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@leemthompo leemthompo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanx! Just one minor syntax fix required 🚀

@leemthompo
Copy link
Contributor

leemthompo commented Oct 3, 2024 •
edited
Loading

@moxarth-elastic few minor process points for future PRs in the Elasticsearch repo:

  • Try to preface PR title with [DOCS][Connectors] ...
  • Add the >docs label
  • Request reviews from writers and devs
  • Always specify what versions are concerned in the PR description, because we might need to cherrypick changes to the previous versions which live in the private repo
  • Delete the checklist from the PR description to make it easier to read

@leemthompo leemthompo added the :SearchOrg/Extract&Transform Label for the Search E&T team label Oct 3, 2024
@elasticsearchmachine elasticsearchmachine added Team:Search - Extract & Transform Team:SearchOrg Meta label for the Search Org (Enterprise Search) labels Oct 3, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ingestion-team (Team:Search - Extract & Transform)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/search-eng (Team:SearchOrg)

@leemthompo leemthompo removed the :SearchOrg/Extract&Transform Label for the Search E&T team label Oct 3, 2024
@elasticsearchmachine elasticsearchmachine removed Team:Search - Extract & Transform Team:SearchOrg Meta label for the Search Org (Enterprise Search) labels Oct 3, 2024
@moxarth-rathod
Copy link
Contributor Author

moxarth-rathod commented Oct 4, 2024 •
edited
Loading

@moxarth-elastic few minor process points for future PRs in the Elasticsearch repo:

  • Try to preface PR title with [DOCS][Connectors] ...
  • Add the >docs label
  • Request reviews from writers and devs
  • Always specify what versions are concerned in the PR description, because we might need to cherrypick changes to the previous versions which live in the private repo
  • Delete the checklist from the PR description to make it easier to read

Noted, Thanks!
And FYI, i don't have enough access to add labels in the PR.

@mark-vieira mark-vieira added auto-backport Automatically create backport pull requests when merged and removed auto-backport-and-merge labels Oct 4, 2024
@moxarth-rathod
Copy link
Contributor Author

@leemthompo can you please re-run the CI and merge the PR? I don't have merge access.

@leemthompo
Copy link
Contributor

@elasticmachine update branch

@leemthompo
Copy link
Contributor

@moxarth-elastic how many Elastic versions should this be backported to?

leemthompo
leemthompo reviewed Oct 7, 2024
View reviewed changes
@leemthompo leemthompo merged commit e1bba9b into elastic:main Oct 7, 2024
7 checks passed
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

The backport operation could not be completed due to the following error:

An unexpected error occurred when attempting to backport this PR.

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 113994

@leemthompo
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Questions ?

Please refer to the Backport tool documentation

@leemthompo leemthompo mentioned this pull request Oct 7, 2024
Merged
leemthompo pushed a commit to leemthompo/elasticsearch that referenced this pull request Oct 7, 2024
@moxarth-rathod
[Zoom] Update existing scopes with granular scopes (elastic#113994)
3427cf5 
(cherry picked from commit e1bba9b)
elasticsearchmachine pushed a commit that referenced this pull request Oct 7, 2024
@leemthompo @moxarth-rathod
[Zoom] Update existing scopes with granular scopes (#113994) (#114238)
183e251 
(cherry picked from commit e1bba9b)

Co-authored-by: moxarth-elastic <[email protected]>
@moxarth-rathod
Copy link
Contributor Author

@moxarth-elastic how many Elastic versions should this be backported to?

we can do it for 8.11.0 and later versions - elastic/connectors#1504.

matthewabbott pushed a commit to matthewabbott/elasticsearch that referenced this pull request Oct 10, 2024
@moxarth-rathod @matthewabbott
[Zoom] Update existing scopes with granular scopes (elastic#113994)
0ddadcf
davidkyle pushed a commit to davidkyle/elasticsearch that referenced this pull request Oct 13, 2024
@moxarth-rathod @davidkyle
[Zoom] Update existing scopes with granular scopes (elastic#113994)
ebd54a2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leemthompo leemthompo leemthompo approved these changes

Assignees

@leemthompo leemthompo

Labels

auto-backport Automatically create backport pull requests when merged backport pending >docs General docs changes external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Docs Meta label for docs team v8.16.0 v9.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@moxarth-rathod @elasticsearchmachine @leemthompo @andreidan @mark-vieira @elasticmachine